Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): make autoscaler deploys more robust #156

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Conversation

mnaser
Copy link
Member

@mnaser mnaser commented Jul 7, 2023

  • fix(helm): make upgrades more robust
  • fix(helm): skip deploying autoscaler unnecessarily

The current way we were handling upgrades of Helm releases could
catch race conditions because we checked for status and then ran
the upgrade.  It's possible that both upgrades pass the status
check and then upgrade at the same time.

Instead, it's probably more wise to just do the upgrade and skip
failing if we get any error that the task is already happening
or that the release already exists.
If there are any changes happening to node groups, we do not need
to deploy the Helm release for the auto scaler as there will not
be any changes to it.  This will reduce the possibility for any
race conditions happening with too many calls at once if there are
multiple node groups being created at once for example.
@mnaser mnaser merged commit e1abbc8 into main Jul 7, 2023
26 checks passed
@mnaser mnaser deleted the fix-helm-release branch July 7, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant